cmd,internal/testrunner{,/script}: implement script test reporting #3100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it is not possible to direct tests to not emit any script run information during testing.
efd6
added
enhancement
teresaromero
reviewed
Dec 2, 2025
Contributor
Author
|
/test |
Collaborator
💚 Build Succeeded
History
cc @efd6 |
teresaromero
approved these changes
Dec 3, 2025
mrodm
reviewed
Dec 3, 2025
Comment on lines
+35
to
+37
| if s.Link.URL == nil { | ||
| return s.Reason | ||
| } |
Contributor
There was a problem hiding this comment.
I see that this is needed because testscript doe snot set the URL for any Github issue.
In other tests, that link is mandatory to set when skipping tests.
https://github.com/elastic/package-spec/blob/ee697d2b4f3673e40888b937a07cced5c73542f6/spec/integration/data_stream/_dev/test/skip.spec.yml#L19
Could this link be added to these tests too ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.
Closes #3053